Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multifile Compilation #382

Merged
merged 6 commits into from
Nov 25, 2021
Merged

Multifile Compilation #382

merged 6 commits into from
Nov 25, 2021

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Nov 24, 2021

There was a regression where multi-files were not compiled correctly anymore
This fixes the issue and adds tests (both unit and integration) to test multifile projects
It also adds test methods that could be used to simulate multiple files during compilation
I also fixed an issue where the correctness tests would sometimes crash with an illegal access exception.
To avoid that, there is now a MainType declared in the tests/tests.rs which can be used when the content of the test struct does not matter. It is currently 1000xusize.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #382 (98a6eb9) into master (b173527) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   93.17%   93.24%   +0.07%     
==========================================
  Files          30       31       +1     
  Lines        9933     9979      +46     
==========================================
+ Hits         9255     9305      +50     
+ Misses        678      674       -4     
Impacted Files Coverage Δ
src/codegen.rs 100.00% <100.00%> (ø)
src/codegen/generators/data_type_generator.rs 95.25% <100.00%> (ø)
src/codegen/generators/pou_generator.rs 91.76% <100.00%> (ø)
src/codegen/generators/variable_generator.rs 98.36% <100.00%> (ø)
src/codegen/llvm_index.rs 97.41% <100.00%> (+0.44%) ⬆️
src/lib.rs 96.01% <100.00%> (+0.17%) ⬆️
src/resolver.rs 96.75% <100.00%> (+0.39%) ⬆️
src/test_utils.rs 100.00% <100.00%> (ø)
src/tests/multi_files.rs 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b173527...98a6eb9. Read the comment docs.

@ghaith ghaith requested a review from riederm November 24, 2021 07:41
Copy link
Collaborator

@riederm riederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@ghaith ghaith merged commit 974ba6b into master Nov 25, 2021
@ghaith ghaith deleted the annotations branch November 25, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants